Temporary Credentials: Add Grafana Assume role authentication option #49
Conversation
src/ConnectionConfig.tsx
Outdated
| AwsAuthType.Default, | ||
| AwsAuthType.Keys, | ||
| AwsAuthType.Credentials, | ||
| AwsAuthType.GrafanaAssumeRole, |
There was a problem hiding this comment.
imo this line is not necessary because we don't want this setting in oss/on prem only in cloud, and in cloud I think we define it in awsAllowedAuthProviders
There was a problem hiding this comment.
on that note, do either of you think it needs to be made more obvious that this option is meant only for cloud? (since this would be the first time an AWS auth option is meant just for cloud, right?)
There was a problem hiding this comment.
Im ok with not putting it in the config for now, since we will probably add it in the docs under AWS authentication once it goes GA. @sarahzinger what do you think?
idastambuk
force-pushed
the
205-temporary-credentials-update-connectionconfig-in-grafana-aws-sdk-to-have-a-new-authentication-provider
branch
from
3bc45da
to
30c516c
Compare
src/SIGV4ConnectionConfig.test.tsx
Outdated
| @@ -8,15 +8,19 @@ import {config} from '@grafana/runtime' | |||
| jest.mock('@grafana/runtime', () => ({ | |||
| ...jest.requireActual('@grafana/runtime'), | |||
| config: { | |||
| awsAllowedAuthProviders: [AwsAuthType.Credentials, AwsAuthType.Keys], | |||
| awsAllowedAuthProviders: [AwsAuthType.Credentials, AwsAuthType.Keys, AwsAuthType.Credentials], | |||
There was a problem hiding this comment.
Is AwsAuthType.Credentials meant to be included twice? Same question for line 21 below.
There was a problem hiding this comment.
Nope, good catch!
idastambuk
deleted the
205-temporary-credentials-update-connectionconfig-in-grafana-aws-sdk-to-have-a-new-authentication-provider
branch
Implements https://github.com/grafana/oss-plugin-partnerships/issues/205