ConnectionConfig: update input width for experimental auth component #52
Conversation
bohandley
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
|
|
|
Looks good with the grafana/aws-sdk part, but I see this in e.g. Athena: 
with the rest of the form with the old width. Most of our datasources have some kind of datasource-specific config fields, so I guess the datasources would have to all be updated at some point? |
src/ConnectionConfig.tsx
Outdated
| @@ -71,6 +71,10 @@ export const ConnectionConfig: FC<ConnectionConfigProps> = (props: ConnectionCon | |||
| loadRegions().then((regions) => setRegions(regions.map(toOption))); | |||
| }, [loadRegions]); | |||
|
|
|||
| const inExperimentalAuthComponent = options.jsonData.inExperimentalAuthComponent; | |||
There was a problem hiding this comment.
Just curious why we would want to store this in options.jsonData vs adding this as a prop on <ConnectionConfig inExperimentalAuthComponent={true} >
I think the downside to storing this in jsonData is then you need to update all the datasource instances right? Maybe easier to add a temporary flag in the javascript rather than update the user's stored datasource configuration, yeah?
There was a problem hiding this comment.
@sarahzinger
Good point! I was having trouble adding the prop to the component with regards to eliminating type errors so I chose to add the flag in the json data, which is not good to update.
For prometheus, we would have to pass the flag into two components, first the SigV4ConnectionConfig and then again into the ConnectionConfig. I can explore doing that and fixing any typing issues that appear.
There was a problem hiding this comment.
@sarahzinger Added as a prop now!
|
@idastambuk, for the Athena issue, this is a good point!
As mentioned above, Prometheus only uses the SigV4ConnectionConfig but I am not sure where the Athena details are defined or what component those details are in. Is the Athena component another wrapper for the connection config used in other data sources? |
Sorry @bohandley, I should probably have used a better example than Athena! Just to answer your question about config forms in Athena (and all other datasources I guess): |
What is this?
This is a small UI change, an update to the input widths for the connection config component, only when it is inside the experimental auth component.
Why is this needed?
The experimental auth component is part of the Config Overhaul project and the Prometheus config has recently been updated to use the new auth component.
Here is what it looks like without the update:
Here is what it looks like with the update:
Notes for the reviewers:
Let me know if you have any questions or have any suggestions!