Temp Credentials: Display External Id #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
fridgepoet
approved these changes
Aug 4, 2023
sarahzinger
force-pushed
the
sarahzinger/display-external-id
branch
from
8d5fa28
to
0568b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could fix the UI a bit I think, but I think this is generally enough to get folks started. Also decided to hide the "endpoint" field in this auth flow because honestly I'm not sure if it will work or not it might make sense to only add that when we know it is supported. (I think it might be?? but I haven't tested it)
To test out this flow you can run grafana/grafana#72821 and install this plugin locally into grafana