Only show grafana assume role on enabled datasources #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
requested review from
fridgepoet and
idastambuk
and removed request for
a team
kevinwcyu
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will hide the temporary credentials ui unless the datasource is on a list of approved datasources.
We had originally considered enabling temp credentials on all datasources at once, but for a smoother rollout it would be better if we did this gradually. Each datasource also currently needs to configure a way to access externalId through a resource endpoint (maybe in the future we could figure out a way to centralize this in one place, but for now this is per-datasource), so it would be better if we hide the UI until we have fully tested and ensured each datasource will work with temp credentials.
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/223