Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor of ConfigSelect #6

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Minor refactor of ConfigSelect #6

merged 3 commits into from
Dec 3, 2021

Conversation

andresmgot
Copy link
Collaborator

@andresmgot andresmgot commented Dec 2, 2021 •
edited

follow up of #4

Re-reading this I was not very happy with the jsonDataPath parameter that I added to the ConfigSelect component. I did it to avoid having to define the onChange function for each data source config but we are losing the strict typing (you could use a jsonDataPath that didn't exist). So I am removing it here.

[EDIT]

I also modified the InlineInput component with the same logic

sarahzinger
sarahzinger approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this feels like more predictable behavior to me as well! Glad to hear it was doable :)

@andresmgot andresmgot merged commit 11a4862 into main Dec 3, 2021
@andresmgot andresmgot deleted the ConfigSelectReview branch December 3, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@sunker sunker Awaiting requested review from sunker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andresmgot @sarahzinger