Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 18 #64

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Support Node 18 #64

merged 4 commits into from
Oct 23, 2023

Conversation

kevinwcyu
Copy link
Contributor

@kevinwcyu kevinwcyu commented Oct 17, 2023 •
edited

  • Made the minimal amount of updates to dependencies to support Node 18
  • Drone file updated to use the latest image with Node 18
  • Removed references to @grafana/toolkit in the jest config files.

@kevinwcyu kevinwcyu force-pushed the kevinwcyu/node-18 branch 2 times, most recently from 02f0807 to d73eb07 Compare October 17, 2023 20:48
@kevinwcyu kevinwcyu marked this pull request as ready for review October 18, 2023 17:37
@kevinwcyu kevinwcyu requested a review from a team as a code owner October 18, 2023 17:37
@kevinwcyu kevinwcyu requested review from iwysiu and sarahzinger and removed request for a team October 18, 2023 17:37
@kevinwcyu kevinwcyu merged commit d617516 into main Oct 23, 2023
3 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/node-18 branch October 23, 2023 17:55
@kevinwcyu kevinwcyu mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@idastambuk idastambuk idastambuk approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinwcyu @sarahzinger @idastambuk