Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spellcheck #67

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Add spellcheck #67

merged 4 commits into from
Oct 27, 2023

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Oct 26, 2023

I was adding tests in Athena and I realized one label in FormatSelect in this repo contained "dataframes", which wasn't caught in the spellcheck in the pipeline.

@idastambuk idastambuk changed the title Add spellcheck, pipeline Add spellcheck Oct 26, 2023
@idastambuk idastambuk marked this pull request as ready for review October 26, 2023 17:09
@idastambuk idastambuk requested a review from a team as a code owner October 26, 2023 17:09
@idastambuk idastambuk requested review from sarahzinger, kevinwcyu and andresmgot and removed request for a team, sarahzinger and kevinwcyu October 26, 2023 17:09
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the drone file is missing an update to its signature as well?

@idastambuk
Copy link
Contributor Author

i think the drone file is missing an update to its signature as well?

Done! Also updated the readme with instructions on how to get the drone token :)

@idastambuk idastambuk merged commit 57b9903 into main Oct 27, 2023
3 checks passed
@idastambuk idastambuk deleted the add-spellcheck branch October 27, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants