Connection config: import assumeRoleInstructionsStyle instead of passing it as prop #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
sarahzinger and
kevinwcyu
and removed request for
a team
sarahzinger
approved these changes
Feb 9, 2024
| @@ -19,7 +19,6 @@ interface NewConnectionConfigProps extends ConnectionConfigProps { | |||
| setIsARNInstructionsOpen: (isOpen: boolean) => void; | |||
| awsAssumeRoleEnabled: boolean; | |||
| regions: SelectableValue[]; | |||
| assumeRoleInstructionsStyle: string; | |||
| @@ -305,10 +303,7 @@ export const ConnectionConfig: FC<ConnectionConfigProps> = (props: ConnectionCon | |||
| ); | |||
| }; | |||
|
|
|||
| function getStyles() { | |||
There was a problem hiding this comment.
I don't really mind this style imo. It makes it ever so slightly easier to add other styles later. Or if you ever want to reference a theme or something you can.
That said i agree it doesn't need to go through the useStyles2 hook.
That said how you have it is also fine by me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing some absolutely wild code I added a while ago