Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Query code editor: remove unused parameter #8

Merged
merged 3 commits into from
Dec 16, 2021
Merged

SQL Query code editor: remove unused parameter #8

merged 3 commits into from
Dec 16, 2021

Conversation

andresmgot
Copy link
Collaborator

No need to pass over the getTemplateSrv function since it's only used in the getSuggestions function, which is defined in the plugin, which has access to the TemplateSrv getter.

@andresmgot andresmgot requested review from a team, fridgepoet, vickyyyyyyy and sarahzinger and removed request for a team December 16, 2021 13:06
@andresmgot andresmgot merged commit dd4a481 into main Dec 16, 2021
@andresmgot andresmgot deleted the removeUnusedParam branch December 16, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridgepoet fridgepoet fridgepoet approved these changes

@vickyyyyyyy vickyyyyyyy Awaiting requested review from vickyyyyyyy vickyyyyyyy is a code owner automatically assigned from grafana/aws-datasources

@sarahzinger sarahzinger Awaiting requested review from sarahzinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andresmgot @fridgepoet