Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move grafana/grafana AWS metrics maps into this package #135

Closed
tristanburgess opened this issue Apr 16, 2024 · 2 comments · Fixed by grafana/grafana#88733
Closed

Move grafana/grafana AWS metrics maps into this package #135

tristanburgess opened this issue Apr 16, 2024 · 2 comments · Fixed by grafana/grafana#88733
Assignees
@iwysiu
Labels
type/feature-request New feature or request

Comments

@tristanburgess
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Discussed in Slack

Describe the solution you'd like
We would like to migrate the metrics map library currently in grafana/grafana's tsdb package. Currently, users of the metrics map as is requires wholesale importing grafana/grafana as a Go package, which can cause false positive build failures from detecting Go vulnerabilities on other unrelated areas of that package.
@tristanburgess tristanburgess added the type/feature-request New feature or request label Apr 16, 2024
@njvrzm
Copy link
Contributor

njvrzm commented May 31, 2024

Maybe wait til this open PR is merged: grafana/grafana#88418

@iwysiu iwysiu self-assigned this May 31, 2024
This was referenced May 31, 2024
Merged
Merged
@iwysiu
Copy link
Contributor

iwysiu commented Jun 6, 2024

@tristanburgess Done, and released in v0.26.1 of grafana-aws-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwysiu iwysiu

Labels
type/feature-request New feature or request
Projects
AWS Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cloudwatch: Use the metric map from grafana-aws-sdk grafana/grafana
3 participants
@tristanburgess @iwysiu @njvrzm