Don't use the set endpoint to get the assume role credentials #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
approved these changes
Dec 18, 2023
sarahzinger
reviewed
Dec 18, 2023
| @@ -319,3 +324,30 @@ func (sc *SessionCache) GetSession(c SessionConfig) (*session.Session, error) { | |||
|
|
|||
| return sess, nil | |||
| } | |||
|
|
|||
| // getSTSEndpoint checks if the set endpoint is a fips endpoint, and if so, returns the STS fips endpoint for the same region | |||
| func getSTSEndpoint(endpoint string) string { | |||
There was a problem hiding this comment.
no idea if this is helpful but there is an Endpoints package in aws-sdk-go I wonder if it has something for this? https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/
There was a problem hiding this comment.
Unfortunately they don't have a helper for checking if something is a fips endpoint 😞 I think I checked and there wasn't a helper for gettting the service from a string either.
idastambuk
approved these changes
Jan 2, 2024
iwysiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/grafana/support-escalations/issues/8225 and grafana/athena-datasource#296 a bug was reported regarding authentication with an endpoint and assume role. The problem was that we were setting the endpoint for the Athena service on the session that we were passing to the STS service to fetch the credentials.
Under the assumption that a user who wants to use a FIPS endpoint for a service would want to use a FIPS endpoint to get the assume role credentials, I added a function to check whether the endpoint is a FIPS endpoint and return the correct endpoint. I'm not sure that this is correct to do since I was reading that there are no real rules for how AWS endpoints are named (though from what I can tell, all the fips endpoints we'd expect would be caught by this), and I'm not sure if the users actually care if the credentials are fetched with FIPS or if that just applies to their data.