Update to sqlutil helpers #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sarahzinger
approved these changes
Jan 23, 2024
iwysiu
approved these changes
Jan 23, 2024
pkg/sql/api/api.go
Outdated
There was a problem hiding this comment.
It may also make sense to add aws.Context to the arguments for the SQL.Stop function, since it's also a request.
There was a problem hiding this comment.
Makes sense, but I think I'll leave that for a separate PR.
go.mod
Outdated
| @@ -4,18 +4,22 @@ go 1.21 | |||
|
|
|||
| toolchain go1.21.3 | |||
|
|
|||
| // TODO: remove both of the following before release | |||
There was a problem hiding this comment.
Reminder to remove these when you merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the sdk to bring it in sync with changes to
sqldsandgrafana-plugin-sdk-gorelated to grafana/sqlds#85 and grafana/grafana-plugin-sdk-go#858.Depends on grafana/sqlds#105, grafana/grafana-plugin-sdk-go#862 and grafana/grafana-plugin-sdk-go#863.