Move SigV4 config and middleware here #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sarahzinger
approved these changes
Mar 15, 2024
| // SigV4MiddlewareName the middleware name used by SigV4Middleware. | ||
| const SigV4MiddlewareName = "sigv4" | ||
|
|
||
| var newSigV4Func = New |
There was a problem hiding this comment.
So we have one middleware calling another middleware now... https://github.com/grafana/grafana-aws-sdk/blob/main/pkg/sigv4/sigv4.go#L80-L82
Does this second middeware do anything that the first middleware doesn't do? Maybe better logging and something like that? Or is this just the format that the prometheus datasource expects?
There was a problem hiding this comment.
yeah, this middleware is just a wrapper around the other middleware. Its goal is to do the transformation from httpclient.Options -> sigv4.Options. It could probably be refactored and only have one but it would imply changing the signature of that New method (so a breaking change).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things: