Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade all deps #134

Merged
merged 3 commits into from
May 14, 2024
Merged

upgrade all deps #134

merged 3 commits into from
May 14, 2024

Conversation

tristanburgess
Copy link
Contributor

govulncheck ./...
Scanning your code and 581 packages across 96 dependent modules for known vulnerabilities...

=== Symbol Results ===

No vulnerabilities found.

@tristanburgess tristanburgess requested a review from a team as a code owner April 16, 2024 14:22
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant

This comment was marked as outdated.

commands:
- go install golang.org/x/vuln/cmd/govulncheck@latest
- govulncheck ./...

---
kind: signature
hmac: dabf2613950066fd502238aeacf42600215e93853dc525e055d32027090867db
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to update this myself/if I'm supposed to

$ mage drone
Error: you must provide your Drone access token.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and signed the change. For future reference, if you log into drone and navigate to https://drone.grafana.net/account you can get your token, then add it and the server url to your environment. After that mage drone should work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing that and pointing out how to do it in the future!

Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I tried installing this into athena this morning to test it out and ran into a build error so I upgraded some more dependencies and removed the bit about getkin and it seems to work for me now. I pushed up what I have maybe @njvrzm you can give it a final look over?

Copy link
Contributor

@njvrzm njvrzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍🏻 but for the record this does break at least one plugin build (opensearch) so we'll want to be thoughtful about updating them.

@tristanburgess tristanburgess merged commit 1795df6 into main May 14, 2024
3 checks passed
@tristanburgess tristanburgess deleted the tristanburgess/package-upgrades branch May 14, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants