Add the rest of backend sql packages #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
sunker,
a team and
sarahzinger
and removed request for
a team
sarahzinger
approved these changes
Nov 3, 2021
pkg/sql/datasource/datasource.go
Outdated
| "github.com/grafana/sqlds/v2" | ||
| ) | ||
|
|
||
| // AWSDatasource stores a cache of: |
There was a problem hiding this comment.
love how well commented and well named this whole pr is! What would you think about a one sentence explanation for each of these terms, like "a driver is used xyz" just for folks new to these terms?
There was a problem hiding this comment.
added more color to this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package for AWS SQL data sources that define common routes.
Epic at #28
Design doc
Closes #31
This PR implements, mainly, the
AWSDatasourcestruct. The goal of this entity is to provide the methods to retrieve a database or an API instance, supporting multiple connections at the same time. The main concepts are:backend.DataSourceInstanceSettings) with settings specific to the data source.sql.DB.The key point here is that the data source using this library should only worry about defining methods to initialize settings, APIs, databases... and forget about how to handle multiple connections.