Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent function #36

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Add user agent function #36

merged 1 commit into from
Dec 13, 2021

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Nov 8, 2021

This will produce reasonable user-agent string with versions for both the plugin and grafana version

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to send a PR for this. Thanks @ryantxu!

"github.com/grafana/grafana-plugin-sdk-go/build"
)

// GetUserAgentString returns an agent that can be parsed in server logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/making-requests.html#get-http-request-response to let people now how you can add the User-Agent header to a service?

@andresmgot andresmgot mentioned this pull request Nov 10, 2021
15 tasks
@andresmgot
Copy link
Contributor

Merging this since I am going to start using it for a data source.

@andresmgot andresmgot merged commit b5c6292 into main Dec 13, 2021
@fridgepoet fridgepoet deleted the common-user-agent-string branch January 25, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants