Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL data source: expose Init method #38

Merged
merged 1 commit into from
Dec 15, 2021
Merged

SQL data source: expose Init method #38

merged 1 commit into from
Dec 15, 2021

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Dec 15, 2021 •
edited

Just some syntax sugar here. Rather than exposing the StoreConfig method, use an Init method.

sunker
sunker approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresmgot andresmgot merged commit 39abfdf into main Dec 15, 2021
@andresmgot andresmgot deleted the sqlDatasource branch December 15, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunker sunker sunker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andresmgot @sunker