-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: Add missing aria labels on connection config component #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Just checking before approving: any reason why Fastpass is complaining about the select elems but not the inputs (Credential Profile Name for instance)? Or maybe they were not visible when you ran it?
Thanks @yaelleC you're right, the voiceover is not reading the titles of those other inputs. |
Indeed! Turns out support of placeholders for screen readers is not consistent :( (see: https://www.davidmacd.com/blog/is-placeholder-accessible-label.html) So aria labels could be a good quick-fix solution and we can look into a better one is the issue you raise. 👍 |
I believe this PR needs to be moved to the new frontend repo for aws - https://github.com/grafana/grafana-aws-sdk-react/. |
Thanks |
Accessibility improvement: tracked on grafana/grafana#41206
Closes grafana/grafana#42706
Hey @sarahzinger here's a go at adding aria-labels (indirectly?) for CloudWatch. Not sure at all if that's correct. Let me know what you think.