Use data source instance HTTP options in AWS sessions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
sunker,
a team,
yaelleC and
iwysiu
and removed request for
a team
iwysiu
approved these changes
Jan 13, 2022
| return sessionCache.GetSession(region, settings) | ||
| } | ||
|
|
||
| func WithUserAgent(sess *session.Session, name string) { |
There was a problem hiding this comment.
Good call adding this to the constructor!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetSessionnow accepts the data source configuration and it's used to obtain HTTP client options.We were already using different parameters: the region, the default region, the AWS settings, the user agent... I gathered all those in a single struct that is now the only parameter for
GetSession. This simplification implies a breaking change though.First step of #39089