Fix ec2 with endpoint connection #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Yes looks good! Would be great if we could test this in ec2 (a workspace in aws would be even better) using cloudwatch before releasing a new version of the sdk.
Steps to reproduce in the escalation, and you should be able to use endpoint monitoring.us-east-2.amazonaws.com while testing.
|
Nice @iwysiu! We also need to release the sdk and bump the version in all plugins that use it. |
|
we may want to work on #46 before updating all the plugins |
|
Yeah makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes grafana/support-escalations#1531