Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to marshal errors correctly #55

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Conversation

aangelisc
Copy link
Contributor

Forms a part of grafana/grafana#50238.

Fixes grafana/athena-datasource#141 as an error will be correctly parsed and returned as seen in the screenshot below:
image

@aangelisc aangelisc self-assigned this Jun 6, 2022
@aangelisc aangelisc requested a review from andresmgot June 6, 2022 14:10
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! I have some small suggestions.

pkg/sql/routes/routes.go Outdated Show resolved Hide resolved
pkg/sql/routes/routes.go Outdated Show resolved Hide resolved
pkg/sql/routes/routes.go Outdated Show resolved Hide resolved
@aangelisc aangelisc requested a review from andresmgot June 7, 2022 08:35
pkg/sql/routes/routes.go Outdated Show resolved Hide resolved
pkg/sql/routes/routes.go Outdated Show resolved Hide resolved
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aangelisc aangelisc merged commit 42a4521 into main Jun 8, 2022
@aangelisc aangelisc deleted the improved-error-handling branch June 8, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Error message not forwarded when listing resources in ConfigEditor
2 participants