Chore: Allow logger to be overridden #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andresmgot
approved these changes
Jun 22, 2022
| t.Cleanup(func() { | ||
| plog = origLogger | ||
| backend.Logger = origLogger |
There was a problem hiding this comment.
I am surprised you can mock an exported variable like this but the tests are passing so it should be fine 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By assigning
backend.Loggerto a variable it makes it impossible to override the logger implementation when grafana-aws-sdk is used in Grafana itself for the core CloudWatch datasource. This removes the assignment ofbackend.Loggerto a variable.