Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ec2 role cred provider to remote cred provider #62

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

robbierolin
Copy link
Contributor

@robbierolin robbierolin commented Sep 13, 2022

This PR updates the Workspace IAM Role provider to pull credentials from both EC2 IAM Roles and ECS Task IAM Roles

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022

CLA assistant check
All committers have signed the CLA.

@sunker
Copy link
Collaborator

sunker commented Sep 14, 2022

Hi @robbierolin! Would you mind creating an issue that describes the need for this change?

Copy link
Collaborator

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunker
Copy link
Collaborator

sunker commented Sep 20, 2022

This PR is still in draft mode @robbierolin. I'm ready to merge if you are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants