Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass query args to GetAsyncDB #71

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Pass query args to GetAsyncDB #71

merged 1 commit into from
Feb 22, 2023

Conversation

kevinwcyu
Copy link
Contributor

@kevinwcyu kevinwcyu commented Feb 9, 2023

Work for Athena query result reuse work.

This passes the ConnectionArgs to the Datasource's GetAsyncDB method. The ConnectionArgs are specific to a query. Currently, synchronous queries already get the connection args (this is handled in sqlds https://github.com/grafana/sqlds/blob/f35c5a62f66c02aef63b260c1e0a25568ae698b6/datasource.go#L169).

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fridgepoet
Copy link
Member

I notice that near line 146, GetDBFromQuery in sqlds itself has the connection args that you originally linked in sqlds. What is the difference between the db there and the asyncDB from GetAsyncDB?

@kevinwcyu
Copy link
Contributor Author

I notice that near line 146, GetDBFromQuery in sqlds itself has the connection args that you originally linked in sqlds. What is the difference between the db there and the asyncDB from GetAsyncDB?

@fridgepoet, the db is an actual sql connection i believe. whereas the asyncDB provides the methods for the async flow, i.e. starting a query, getting its status, etc.

@kevinwcyu kevinwcyu merged commit ca3c979 into main Feb 22, 2023
@kevinwcyu kevinwcyu deleted the kevinwcyu/athena-qrr branch February 22, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants