Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade grafana-plugin-sdk-go to the latest version #95

Merged
merged 9 commits into from
Aug 17, 2023
Merged

Upgrade grafana-plugin-sdk-go to the latest version #95

merged 9 commits into from
Aug 17, 2023

Conversation

idastambuk
Copy link
Contributor

No description provided.

@idastambuk idastambuk requested a review from a team as a code owner August 8, 2023 14:23
@idastambuk idastambuk requested a review from a team as a code owner August 8, 2023 15:23
idastambuk
idastambuk commented Aug 8, 2023
View reviewed changes
.drone.yml
@@ -11,17 +11,17 @@ platform:

steps:
- name: build
image: grafana/grafana-plugin-ci:1.4.1-alpine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting some errors that were apparently related to pipelines running in Go < v1.20 so had to update this image too

sarahzinger
sarahzinger requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build seems to be hanging for mysterious reasons??

Screenshot 2023-08-09 at 4 44 39 PM

Also looks like we're committing some file called .DS_Store which seems unintentional?

@kevinwcyu
Copy link
Contributor

you can run mage drone to update the signature. that should unblock the build. you'll need the drone cli setup with DRONE_SERVER and DRONE_TOKEN which you can find in when you login to your drone account page

@idastambuk
Copy link
Contributor Author

you can run mage drone to update the signature. that should unblock the build. you'll need the drone cli setup with DRONE_SERVER and DRONE_TOKEN which you can find in when you login to your drone account page

That worked, thanks so much!

sarahzinger
sarahzinger approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio! Just checking were you able to test this manually with grafana and/or another datasource! Let me know if you want help doing so. Thanks for looking into this!

@idastambuk
Copy link
Contributor Author

Coolio! Just checking were you able to test this manually with grafana and/or another datasource! Let me know if you want help doing so. Thanks for looking into this!

Tested with Cloudwatch and Athena and looks good!

@idastambuk
Copy link
Contributor Author

Just need someone from @grafana/grafana-operator-experience-squad to review this as well 🙏🏻🙏🏻🙏🏻

leandro-deveikis
leandro-deveikis approved these changes Aug 17, 2023
View reviewed changes
Copy link

@leandro-deveikis leandro-deveikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@idastambuk idastambuk merged commit 76b13e1 into main Aug 17, 2023
3 checks passed
@idastambuk idastambuk deleted the chore/update-grafana-sdk branch August 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@leandro-deveikis leandro-deveikis leandro-deveikis approved these changes

@fridgepoet fridgepoet Awaiting requested review from fridgepoet fridgepoet is a code owner automatically assigned from grafana/aws-datasources

@jcalisto jcalisto Awaiting requested review from jcalisto jcalisto was automatically assigned from grafana/grafana-operator-experience-squad

@jrbgraf jrbgraf Awaiting requested review from jrbgraf jrbgraf was automatically assigned from grafana/grafana-operator-experience-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@idastambuk @kevinwcyu @sarahzinger @leandro-deveikis