Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache to renew retriever if token is expired #111

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

aangelisc
Copy link
Contributor

@aangelisc aangelisc commented Mar 15, 2024

A bug in the cache didn't check the expiry times of ID tokens for the OBO retriever. This meant that even when the token was expired and a new one available, the new token would not be used as the old one was present in the cache.

Fixes #124

@aangelisc aangelisc requested a review from kostrse March 15, 2024 20:25
@aangelisc aangelisc self-assigned this Mar 15, 2024
@aangelisc aangelisc requested a review from a team as a code owner March 15, 2024 20:25
@aangelisc aangelisc added the bug Something isn't working label Mar 15, 2024
Copy link
Contributor

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Through tests! Everything looks good but just wondering about one thing

aztokenprovider/token_cache.go Show resolved Hide resolved
@aangelisc aangelisc merged commit 020308e into main Mar 18, 2024
3 checks passed
@aangelisc aangelisc deleted the andreas/update-cache branch March 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cache to renew retriever if token is expired
2 participants