Update azure sdk and fix breaking changes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oscarkilhed
commented
Nov 21, 2022
oscarkilhed
commented
Nov 21, 2022
andresmgot
reviewed
Nov 22, 2022
There was a problem hiding this comment.
As far as I can see, this is fine (only one comment about the cache key). Were you able to test this in Grafana? (I am getting some compilation errors)
Any opinions @kostrse ?
oscarkilhed
force-pushed
the
oscark/update-azure-sdk
branch
from
4ec568e
to
ee8a4aa
Compare
andresmgot
approved these changes
Nov 22, 2022
|
@andresmgot Let me review, do not merge without me. |
kostrse
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a stab at updating the azure SDK to
1.01.2