Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back customized cloud identifier #22

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Add back customized cloud identifier #22

merged 1 commit into from
Dec 15, 2022

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Dec 15, 2022 •
edited

Customized cloud was removed in #14 but it's still used in Grafana.

cc / @kostrse @ms-hujia

@andresmgot andresmgot requested a review from a team as a code owner December 15, 2022 14:15
@andresmgot andresmgot merged commit 3ba629e into main Dec 15, 2022
@andresmgot andresmgot deleted the azsettingsCustomized branch December 15, 2022 14:16
@kostrse
Copy link
Collaborator

kostrse commented Dec 15, 2022 •
edited

Sorry, where is it used? You could give me time to look at it before.

@kostrse
Copy link
Collaborator

kostrse commented Dec 16, 2022

azcredentials.AzureClientSecretCredentials has Authority field.
When it set, value of the cloud can be absolutely anything.

No need to pollute SDK with it.

grafana-azure-sdk-go/aztokenprovider/token_provider.go

Line 98 in 3ba629e

if credentials.Authority != "" {

@andresmgot
Copy link
Contributor Author

please sync with @ms-hujia about this @kostrse. This PR is just to avoid the breaking change in this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andresmgot @kostrse @aangelisc