Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export const Azure config keys #37

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Export const Azure config keys #37

merged 1 commit into from
Sep 7, 2023

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Sep 7, 2023

This is necessary so that Grafana is able to re-use these keys so that this information can be passed via plugin request instead of env vars.

@wbrowne wbrowne requested a review from a team as a code owner September 7, 2023 09:29
@wbrowne wbrowne self-assigned this Sep 7, 2023
@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wbrowne, if I'm understanding this correctly will Grafana be importing these keys and then if the environment vars are set the data will by passed via requests made to plugins? How will Grafana know which plugin requests to append this data to (or will it be for all plugins by default)?

@wbrowne
Copy link
Member Author

wbrowne commented Sep 7, 2023

Hey @wbrowne, if I'm understanding this correctly will Grafana be importing these keys and then if the environment vars are set the data will by passed via requests made to plugins? How will Grafana know which plugin requests to append this data to (or will it be for all plugins by default)?

Hey @aangelisc!

Grafana be importing these keys and then if the environment vars are set the data will by passed via requests made to plugins

Exactly.

How will Grafana know which plugin requests to append this data to (or will it be for all plugins by default)?

Great question. I'd love to find a way where this is only for plugins that need it, but this is currently what we do with the existing env var approach.

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbrowne thank you for the clarification! All good to merge 😊

@wbrowne wbrowne merged commit 3a43226 into main Sep 7, 2023
1 check passed
@wbrowne wbrowne deleted the azure-env-as-cfg branch September 7, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants