Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read settings from context #74

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Read settings from context #74

merged 5 commits into from
Dec 13, 2023

Conversation

aangelisc
Copy link
Contributor

@aangelisc aangelisc commented Dec 12, 2023 •
edited

  • Bump dependencies
  • Add ReadSettings function to read settings from context or fallback to environment
  • Bump go version to 1.21
  • Add ForwardSettingsPlugins which is used in Grafana to determine which plugins should have settings forwarded to them via plugin context

Choosing this PR over grafana/grafana-plugin-sdk-go#836

@aangelisc
Read settings from context
b336015 
- Bump dependencies
- Add ReadSettings function to read settings from context or fallback to environment
@aangelisc aangelisc self-assigned this Dec 12, 2023
@aangelisc aangelisc requested a review from a team as a code owner December 12, 2023 17:27
@aangelisc aangelisc mentioned this pull request Dec 12, 2023
Closed
wbrowne
wbrowne previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aangelisc aangelisc mentioned this pull request Dec 13, 2023
Merged
asimpson
asimpson approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work 🏆

@aangelisc aangelisc merged commit def703c into main Dec 13, 2023
3 checks passed
@aangelisc aangelisc deleted the andreas/update-settings branch December 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@wbrowne wbrowne wbrowne left review comments

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees

@aangelisc aangelisc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aangelisc @asimpson @wbrowne