Cloud settings in Grafana Azure SDK #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aangelisc
reviewed
Jan 9, 2024
|
I resolved the comments. |
aangelisc
approved these changes
Jan 18, 2024
|
@aangelisc I cannot merge myself for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aggregates all cloud-specific settings (endpoints, audiences etc.) into the Grafana Azure SDK, so they could be managed from the single place.
This would allow datasources to pull endpoints etc. from the SDK rather than hardcoding them in the datasource code.
AzureSettingsstructure gets two new methods:Clouds() []AzureCloudInforeturns a list of available clouds (canonical name and display name)GetCloud(cloudName string) (*AzureCloudSettings, error)returns settings for the givencloudName.See grafana/grafana#80187 for reference.