Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AzureAuthEnabled (azure_auth_enabled) value in settings #89

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

itsmylife
Copy link
Contributor

@itsmylife itsmylife commented Feb 1, 2024

This is required as part of Prometheus decoupling/externalisation. We rely on this value in https://github.com/grafana/grafana/blob/6dea3102cb04ddde8e3a4e269a2d80023593150e/pkg/tsdb/prometheus/client/transport.go#L41

In order to read the value it must be exposed.

After merging and having a new release, I will add that key GFAZPL_AZURE_AUTH_ENABLED to grafana/grafana in https://github.com/grafana/grafana/blob/536153c3362782ae7f79e06755e8c7e0cd3b3acd/pkg/plugins/envvars/envvars.go#L154

⚠️ This will be used only in Prometheus

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@asimpson asimpson merged commit a4a06d4 into main Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants