Allow numeric time zone offsets #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time formats were defined with a trailing "Z" which only allowed times in UTC to be parsed for these formats. Replacing "Z" with "Z07:00" makes it possible to parse numeric time zone offsets as well.
|
@marcusolsson Do you already know when this PR could be merged? |
|
|
|
Hi @tolzhabayev, @leventebalogh and @yesoreyeram |
|
@mluppi - Thank you for the PR. I will take a look next week. Sorry for the delay. Happy New year. |
|
Any news about this? |
yesoreyeram
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time formats were defined with a trailing
Zwhich only allowed times in UTC to be parsed for these formats. ReplacingZwithZ07:00makes it possible to parse numeric time zone offsets as well. One example is2021-07-08T10:55:00+01:00which conforms to RFC 3339 and contains a numeric time offset.I extended
csv_test.gowith cases for all the changed layout definitions.