Add tokenprovider package #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
a team,
joshhunt and
vickyyyyyyy
and removed request for
a team
sunker
approved these changes
Oct 8, 2021
joshhunt
reviewed
Oct 8, 2021
tokenprovider/token_provider.go
Outdated
| } | ||
|
|
||
| // GetAccessToken implements TokenProvider | ||
| func (tpi *tokenProviderImpl) GetAccessToken() (string, error) { |
There was a problem hiding this comment.
I'm not a golang person, but I find this pattern of short and obtuse variable names in grafana's go code to be really hard to read.
Perhaps this could be like tokenProvider or something else that makes it more readable at first glance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes grafana/grafana#39950
Notes: