move context to GetAccessToken function #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
a team,
joshhunt and
sunker
and removed request for
a team
andresmgot
approved these changes
Oct 19, 2021
tokenprovider/token_provider_gce.go
Outdated
Comment on lines
25
to
27
| func (source *gceSource) getCacheKey() string { | ||
| return source.cacheKey | ||
| } |
There was a problem hiding this comment.
I guess it's a matter of style but if both the function and the property are not exported, what's the point of defining the method?
There was a problem hiding this comment.
This was so tokenProviderImpl could call it. Alternatively, cacheKey could just be a string stored on tokenProviderImpl, but this felt neater.
iwysiu
commented
Oct 19, 2021
tokenprovider/token_provider_gce.go
Outdated
Comment on lines
25
to
27
| func (source *gceSource) getCacheKey() string { | ||
| return source.cacheKey | ||
| } |
There was a problem hiding this comment.
This was so tokenProviderImpl could call it. Alternatively, cacheKey could just be a string stored on tokenProviderImpl, but this felt neater.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have context passed to GetAccessToken instead of the initialize functions