setup CI #8
setup CI #8
Conversation
iwysiu
requested review from
a team,
sarahzinger and
yaelleC
and removed request for
a team
|
|
||
| --- | ||
| kind: signature | ||
| hmac: 37437b11206f698eec8f7642f882760922190d6acd31117902b21e3b26327f6a |
There was a problem hiding this comment.
just curious what does this do?
There was a problem hiding this comment.
The changes have to be signed for drone to run the drone file.
There was a problem hiding this comment.
the signature is obtained from drone.grafana.net so only authenticated people there can modify this file
| @@ -1,4 +1,5 @@ | |||
| //+build mage | |||
| //go:build mage | |||
| // +build mage | |||
There was a problem hiding this comment.
I think mage or vs code automatically changed those for me, but its the mage build tag so it knows what files to parse.
There was a problem hiding this comment.
these are go build tags (the first one is added automatically by the formatter)
A magefile, instead of having a magic name (like Makefile), uses the go build tag //+build mage to indicate that mage should read it. Other than that, there’s nothing special about magefiles and you can name them whatever you like.
|
|
||
| --- | ||
| kind: signature | ||
| hmac: 37437b11206f698eec8f7642f882760922190d6acd31117902b21e3b26327f6a |
There was a problem hiding this comment.
the signature is obtained from drone.grafana.net so only authenticated people there can modify this file
| @@ -1,4 +1,5 @@ | |||
| //+build mage | |||
| //go:build mage | |||
| // +build mage | |||
There was a problem hiding this comment.
these are go build tags (the first one is added automatically by the formatter)
A magefile, instead of having a magic name (like Makefile), uses the go build tag //+build mage to indicate that mage should read it. Other than that, there’s nothing special about magefiles and you can name them whatever you like.
|
my review arrived a minute late 😆 |
Part of #6