Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent double publish from happening #12

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix: prevent double publish from happening #12

merged 1 commit into from
Nov 1, 2022

Conversation

asimpson
Copy link
Contributor

Having a npm script named publish defined means when npm publish is invoked it's also invokes the script after the publish run 馃檮 This fixes this double run by removing the npm script.

@asimpson asimpson requested a review from a team as a code owner October 27, 2022 00:51
andresmgot
andresmgot approved these changes Oct 27, 2022
View reviewed changes
Copy link

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this behavior before 馃槄

aangelisc
aangelisc approved these changes Oct 27, 2022
View reviewed changes
Copy link

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@asimpson asimpson merged commit 5778344 into main Nov 1, 2022
@asimpson asimpson deleted the simpson-double-publish branch November 1, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@aangelisc aangelisc aangelisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asimpson @andresmgot @aangelisc