Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reset button #2

Merged
merged 2 commits into from
Jan 24, 2022
Merged

fix reset button #2

merged 2 commits into from
Jan 24, 2022

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Jan 24, 2022

No description provided.

sarahzinger
sarahzinger approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to explicitly pass null to onReset? I could see someone removing this change in the future and not realize they are introducing a bug?

Also maybe good to add to the changelog?

@iwysiu iwysiu merged commit 139b8cd into main Jan 24, 2022
@iwysiu iwysiu deleted the fix-reset branch January 24, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iwysiu @sarahzinger