Fix: preserve jwt details when switching auth type #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
reviewed
Feb 28, 2022
There was a problem hiding this comment.
Nice @kevinwcyu! Can the onResetApiKey func be removed now?
@dprokop are you using the ConfigEditor from the SDK now? In that case you might want to review this too?
|
@sunker, |
andresmgot
approved these changes
Mar 1, 2022
src/ConnectionConfig.test.tsx
Outdated
Comment on lines
182
to
184
| clientEmail: 'test@grafana.com', | ||
| defaultProject: 'test-project', | ||
| tokenUri: 'https://accounts.google.com/o/oauth2/token', |
There was a problem hiding this comment.
nit: It'd be nice to have these properties in a object outside the test so it's not needed to repeat it every time.
kevinwcyu
requested review from
sunker and
vickyyyyyyy
and removed request for
a team
andresmgot
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
Preserves existing JWT details when switching between auth types.