Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make file input accessible via keyboard #9

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

asimpson
Copy link
Contributor

closes #8

@asimpson asimpson requested a review from yaelleC October 18, 2022 17:44
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2022

CLA assistant check
All committers have signed the CLA.

Copy link

@yaelleC yaelleC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM
Makes me wonder why we have a LinkButton component at all 🤷‍♀️ 😄 ?
But maybe it's only not accessible because missing an src prop or something like that.

In any case, for the JWT a11y issue your fix works best 👍

@asimpson
Copy link
Contributor Author

@yaelleC There could be scenarios where LinkButton makes sense? I can't think of one right now. I think a button is better here because links are typically used to signal that an action would navigate you somewhere. A button indicates something is happening on the current page.

@asimpson asimpson merged commit 10539b2 into main Oct 19, 2022
@asimpson asimpson deleted the simpson-jwt-button-a11y branch October 19, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1: JWT upload button isn’t actionable from keyboard
3 participants