Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable public rendering. #363

Closed
vukmirovic98 opened this issue Aug 23, 2022 · 3 comments
Closed

Option to enable public rendering. #363

vukmirovic98 opened this issue Aug 23, 2022 · 3 comments
Labels
type/enhancement New feature or request

Comments

@vukmirovic98
Copy link

What would you like to be added:
A config option (preferably true/false) to enable/disable session requirement for the render to start.
Why is this needed:
Ease of access (on secure networks) where we do not want to grant anonymous access to all created dashboards.

@joanlopez joanlopez self-assigned this Sep 12, 2022
@joanlopez joanlopez added the type/enhancement New feature or request label Sep 12, 2022
@joanlopez
Copy link
Collaborator

joanlopez commented Sep 12, 2022

Hi @vukmirovic98,

I'm sorry, but during our internal discussions to manage the most recent security fix related with the Grafana Image Renderer, we explicitly decided to do not allow untrusted communications (requests), at least not by default, because we consider the user's security primordial.

Of course, that's not a definitive answer to your feature request, but what I can say so far is that we'll need to internally discuss it more calmly and evaluate the possibility of letting users to (manually and voluntarily) run the Image Renderer in an insecure way.

Thanks! cc/ @jmatosgrafana

@joanlopez joanlopez removed their assignment Sep 12, 2022
@lgogolin
Copy link

It already has support for remote storage like S3 for alerting. Implementing this for rendering would be sufficient.

Currently it's impossible to have direct image rendering used withing production systems.
Grafana would have to be exposed public and whats even worse authentication would have to be disable to share rendered images in Slack messages for example

I added discussion about that in grafana/grafana#60386

@AgnesToulet
Copy link
Contributor

Hi! I think what you wrote in the discussion in grafana/grafana#60386 makes sense. We'll discuss internally to decide how we want to handle it (implement your suggestion or do it a bit differently) and, then, open an issue in grafana/grafana to track this work.

However, if we do what you suggested, I don't see anything to be done in the image renderer itself so I'll close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants