Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Image Renderer settings coherency (standalone vs plugin) #392

Closed
joanlopez opened this issue Jan 2, 2023 · 2 comments · Fixed by #477
Closed

Review Image Renderer settings coherency (standalone vs plugin) #392

joanlopez opened this issue Jan 2, 2023 · 2 comments · Fixed by #477
Assignees
Labels
type/enhancement New feature or request

Comments

@joanlopez
Copy link
Collaborator

joanlopez commented Jan 2, 2023

What happened:

As mentioned here, certain configuration settings are only available when the Image Renderer is deployed as gRPC plugin but not when running it as standalone application, with no apparent reason.

So, would be good to review all of them and evaluate which (if any) should be supported as well when running the Image Renderer as a standalone application, and fix them.

What you expected to happen:

Review Image Renderer settings to be "coherent" between standalone and plugin modes, unless there's a reason to don't do it.

How to reproduce it (as minimally and precisely as possible):

N/A

Anything else we need to know?: N/A

Environment:

  • Grafana Image Renderer version: N/A
  • Grafana version: N/A
  • Installed plugin or remote renderer service: N/A
  • OS Grafana Image Renderer is installed on: N/A
  • User OS & Browser: N/A
  • Others: N/A
@rhorvath rhorvath added the type/enhancement New feature or request label Apr 6, 2023
@AgnesToulet
Copy link
Contributor

Hi @joanlopez!

Actually, all the settings are available in standalone mode through the config.json file. But I agree that settings management is currently a bit messy and it could be worth to improve it.

The reverse (settings available in standalone mode and not through plugin env variable) is a real problem though, see #317.

@joanlopez
Copy link
Collaborator Author

But I agree that settings management is currently a bit messy and it could be worth to improve it.

Yeah, honestly I didn't go very deep on what is available on each (plugin vs standalone), and what can be configured with different mechanisms (config file, environment variables, etc), but I agree the goal of this issue should be to improve the settings management in general.

I probably mis-explained it, but iirc what I was thinking when I said that a certain setting is not available on the standalone mode was more specifically that you cannot configure/override it through environment variables, or at least I guess some settings should be here to make that possible.

In any case, sorry for the vague description, and happy to see that we're aligned (there's lot of room for improvements on settings' management) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants