Config: Improve consistency between plugin and server mode #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
commented
Oct 24, 2023
src/config.ts
Outdated
There was a problem hiding this comment.
This file was splitted between config/*.ts, plugin/v2/config.ts and service/config.ts files.
AgnesToulet
requested review from
a team,
juanicabanas and
evictorero
and removed request for
a team
evictorero
reviewed
Nov 1, 2023
evictorero
approved these changes
Nov 6, 2023
|
Hello, сould you give us an idea of when this improvement will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the configuration codebase to de-duplicate the code that handles setting the config via environment variables in plugin mode and in server mode.
It also improves the consistency between how you can configure the image renderer as a plugin and as a remote server with environment variables. This adds the following env variables:
RENDERING_LANGUAGE(server mode)RENDERING_VIEWPORT_WIDTH(server mode)RENDERING_VIEWPORT_HEIGHT(server mode)RENDERING_VIEWPORT_DEVICE_SCALE_FACTOR(server mode)RENDERING_VIEWPORT_MAX_WIDTH(server mode)RENDERING_VIEWPORT_MAX_HEIGHT(server mode)RENDERING_VIEWPORT_MAX_DEVICE_SCALE_FACTOR(server mode)GF_PLUGIN_RENDERING_TIMING_METRICS(plugin mode) andRENDERING_TIMING_METRICS(server mode)Fixes #392 and fixes #317
Associated doc PR: grafana/grafana#77042