Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run image renderer under non-root Grafana user. Fixes #140 #144

Merged
merged 1 commit into from Jul 15, 2021

Conversation

wardbekker
Copy link
Member

No description provided.

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DanCech DanCech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Jul 5, 2021

@wardbekker @aknuds1 why we use 472 id not more than 999 , will you plz explain ?

@spaced
Copy link

spaced commented Jul 15, 2021

PR is open since 2020. any news?

@DanCech DanCech merged commit 86358b4 into master Jul 15, 2021
@DanCech DanCech deleted the wardbekker-image-render-non-root-docker branch July 15, 2021 13:28
@DanCech
Copy link
Contributor

DanCech commented Jul 15, 2021

@VishalLahane 472 is just the https://en.wikipedia.org/wiki/ISO/IEC_9995#ISO/IEC_9995-8 numeric code for GRA ;)

@ghost
Copy link

ghost commented Jul 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants