Add plugin.json to the renderer Docker images #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
approved these changes
Jun 8, 2021
|
Ah sure, I didn't even look for the other Dockerfile. Will take care of that in a second. *Edit: rebased for a single commit. |
mbentley
force-pushed
the
fix-docker-packaging
branch
from
4e27653
to
21731e9
Compare
|
Thanks a lot! Can you also merge with the latest CircleCI change on master? Else I won't be able to merge your PR as the pipeline is failing. |
Signed-off-by: Matt Bentley <mbentley@mbentley.net>
mbentley
force-pushed
the
fix-docker-packaging
branch
from
21731e9
to
a7c98a5
Compare
|
Whoops - sorry read your comment too quickly! Updated from master. |
AgnesToulet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
Signed-off-by: Matt Bentley mbentley@mbentley.net