Add --disable-gpu in the default Chromium args #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marefr
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
LGTM I guess, but wonder what possible issues this might cause for others basically switching from hardware acceleration to software rendering if I understand it correctly? Guess just try, but make sure to make the change clear in the change log should anyone have issues with it.
|
thank you for this ! |
|
It's updated only with a new release. Next release should happen this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some load testing of the application with the
defaultrendering mode, I noticed high CPU and memory slowy going to the roof after the tests were finished. I narrowed down the issue to thenewPagefunction that was (for some requests) hanging forever, preventing the browser to be closed and causing these issues.It seems like adding the
--disable-gpuflag to the Chromium args fixed the issue.Should fix #229