Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _client with _client() to avoid to fail when creating a CSV #372

Merged
merged 1 commit into from Sep 23, 2022

Conversation

spinillos
Copy link
Member

It changes _client with _client() to make CSV works with last puppeteer update.

Fixes: https://github.com/grafana/grafana-image-renderer/issues

@Clarity-89 Clarity-89 linked an issue Sep 23, 2022 that may be closed by this pull request
Copy link
Contributor

@Clarity-89 Clarity-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🎉

@Clarity-89 Clarity-89 merged commit c506856 into master Sep 23, 2022
@Clarity-89 Clarity-89 deleted the fix-csv-rendering branch September 23, 2022 11:41
@Bujupah
Copy link
Contributor

Bujupah commented Oct 21, 2022

_client is a private function and I think it is not recommended doing it that way.
I'd recommend switching to this

    const client = await page.target().createCDPSession();
    await client.send('Page.setDownloadBehavior', {
      behavior: 'allow',
      downloadPath,
    });

@spinillos @Clarity-89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV rendering doesn't work after dependencies upgrade
3 participants