Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay after full page waiting time #382

Closed
wants to merge 6 commits into from

Conversation

spinillos
Copy link
Member

It adds some extra waiting time to full page screenshots. This value is configurable.

Why? Because right now we don't have any mechanism to detect when the panel is completely rendered. The waiting time condition looks for a element that exists when the panel loaded its data and it starts to render it. But it doesn't mean that the panel is completely rendered and sometimes we take the screenshot during the rendering getting panels partially rendered.

Also we detected that loading icon and the element that indicates that the panel is ready to render could exist at the same time during this transition. So we added an extra check to guarantee that the loading icons are 0.

We need to maintain the rest of the conditions because we could receive 0 loading icons at the moment that we open the page to render.

src/browser/browser.ts Outdated Show resolved Hide resolved
@AgnesToulet
Copy link
Contributor

Closing this as we didn't receive any other user feedback about this, and this may be improved with the scenes migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants