Add delay after full page waiting time #382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds some extra waiting time to full page screenshots. This value is configurable.
Why? Because right now we don't have any mechanism to detect when the panel is completely rendered. The waiting time condition looks for a element that exists when the panel loaded its data and it starts to render it. But it doesn't mean that the panel is completely rendered and sometimes we take the screenshot during the rendering getting panels partially rendered.
Also we detected that loading icon and the element that indicates that the panel is ready to render could exist at the same time during this transition. So we added an extra check to guarantee that the loading icons are 0.
We need to maintain the rest of the conditions because we could receive 0 loading icons at the moment that we open the page to render.