Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove or fix non-working main dashboard in play.grafana.org #151

Closed
2 tasks done
iwysiu opened this issue Jan 27, 2023 · 4 comments · Fixed by #167
Closed
2 tasks done

Chore: Remove or fix non-working main dashboard in play.grafana.org #151

iwysiu opened this issue Jan 27, 2023 · 4 comments · Fixed by #167

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Jan 27, 2023

The main dashboard on play.grafana doesn't work, so it should be either fixed or removed.

  • Fix play.grafana.org Main Dashboard. Or delete it.
  • Fix Main Dashboard in Sample Dashboards. Or delete it. May be nice to include a text box linking to the doc for how to set it up.
@fridgepoet fridgepoet self-assigned this Feb 2, 2023
@fridgepoet fridgepoet changed the title Chore: Remove or fix non-working main dashboard in play.grafana.com Chore: Remove or fix non-working main dashboard in play.grafana.org Feb 7, 2023
@fridgepoet
Copy link
Member

fridgepoet commented Feb 7, 2023

I've requested some assistance in getting permissions to edit the dashboard.

Here's what can be done to improve the errors in this dashboard:

  • Set a default for sel_entity to Mixer_0_cd81d9fd-3f74-437a-802b-9747ff240837

  • Remove display_entity

  • Edit panel "Selected Alarm History", choose Component Name = AlarmComponent. May need to remove the legend

  • Edit panel "Scene Viewer", open Panel options (to the right). Under "AWS IoT TwinMaker Scene Viewer", choose CookieFactory.
    In the Query Editor: Under Component Type, select "com.example.cookiefactory.alarm". Under Filter, set the value = "ACTIVE".
    Add a query. Get Property Value History by Entity. Entity WaterTank, component WaterTank, property flowRate1.
    Add another query. Get Property Value History by Entity. Entity Mixer_1, component MixerComponent, property Temperature.
    (Not sure if these queries are essential, this is copying from Mixer Alarm Dashboard).
    Edit: Going to leave these queries out for now.

  • Go to Main Dashboard/Settings > Variables. Add a new variable. Type: Text box. Name: kvs_stream_name. Default value: cookiefactory_mixerroom_camera_02
    Show on dashboard: Nothing
    (this is the same as in Mixer Alarm Dashboard)
    Go back to the dashboard. Edit "Video Player" panel. Open Panel options (to the right). Under "AWS IoT TwinMaker Video Player" > Kinesis video stream name, select template variable ${kvs_stream_name}.
    Under Entity, choose ${sel_video_entity}
    Under Component Name, choose ${sel_video_comp}

  • Edit panel "Selected Time Series History"
    In Query Editor, select Entity ${sel_entity}
    Under Selected Properties, choose RPM
    (I cannot get multiple properties to display from one query, so the following is a workaround to get Temperature)
    Duplicate the above query. Change Selected Properties to Temperature.
    Make note that this Time Series is for Mixer only

@iwysiu
Copy link
Contributor Author

iwysiu commented Feb 7, 2023

Nice! Though I'm wondering: does this dashboard fixed up demonstrate anything that we don't already have in the Mixer Alarm Dashboard? Because if it doesn't, I'm inclined to just remove it. (also if I'm understanding the board correctly, I think display_entity can just be removed and replaced with sel_entity in queries)

@fridgepoet
Copy link
Member

fridgepoet commented Feb 8, 2023

@iwysiu Let me know what would like done for these tasks -- Just want to know if you want the demo Main Dashboard to be removed or fixed. And if you want the importable sample Main Dashboard to be removed or fixed.

I have some ongoing work in progress to improve the importable sample Main Dashboard in the repo using the checklist above. If we do decide to continue the work to fix that, I think ultimately play.grafana.org can reflect what is possible using the imported Main Dashboard.

In the meantime I'm going to go ahead and remove the errors on play.grafana.org for Main Dashboard since the work's already done and the permissions granted.

@iwysiu
Copy link
Contributor Author

iwysiu commented Feb 8, 2023

Just to take note of it, we decided to fix up the Main Dashboard this time, in case it is linked to or used as an example anywhere that we don't expect. If it breaks again in the future, we can discuss removing it with AWS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants