Update sample dashboard Main Dashboard #167
Conversation
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.3.6... 🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.3.6... 🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.3.6... 🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.3.6... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
|
Backend code coverage report for PR #167 |
|
Frontend code coverage report for PR #167
|
fridgepoet
changed the title
There was a problem hiding this comment.
I know we've gone back and forth on it, and I wonder how other people feel about, but I feel like this may be a bit tightly bound to the Cookie Factory example. Like there are several Cookie Factory specific variables set, ex. the scene for scene viewer and the row title. I wonder if it would be better to remove the cookie factory link and just have the description of how sel_entity and sel_comp work and a list of other things to set to get it to work, ex. setting the scene in the scene viewer. We can talk about it tomorrow if you want?
|
Also I don't know if you've noticed this, but for the updated Main dashboard, the query editor doesn't load when you open a panel to edit it: |
|
Which environment are you looking at where the query editor doesn't load? Couldn't reproduce on v8.4.7 nor on v9.3.6. |
|
Going to merge this for now but happy to make any changes if there is more feedback from others |
What this PR does / why we need it:
These changes refresh elements of the Main Dashboard so that it works as closely as it was originally intended to with v8.4.7 and ~v9
Which issue(s) this PR fixes:
Fixes #151
Special notes for your reviewer:
Exported this dashboard from v8.4.7 for AMG compatibility
Tested importing it to v9.3.6 to check compatibility with latest-ish Grafana